Add author info for Gary Badwal in Google GenAI integration (TextEmbedder & DocumentEmbedder)#333
Conversation
|
Hi @sjrl, |
|
Hey @garybadwal please wait for this PR #332 to be merged before you open a new one to add author information. Please coordinate with @vblagoje and @bilgeyucel on this. |
|
Ok @sjrl, Thank you. Hi @bilgeyucel, @vblagoje, can any of you guide me into this? |
|
Hi @vblagoje — I'm just checking in to see if you might have a chance to review this PR and guide me if needed. Appreciate your time! |
|
@bilgeyucel let's integrate this one please 👍 |
|
@vblagoje Thanks for your comment on this. Please let me know if there's anything I can do on my end. |
|
No @garybadwal let's just wait for @bilgeyucel - she's super busy atm and she'll take care of this tomorrow. |
|
Ok @vblagoje, thank you so much for your help! Hopefully, @bilgeyucel will be able to check it when she gets a chance. |
|
@garybadwal please update the tile to indicate that we also support GEMINI_API_KEY in addition to GOOGLE_API_KEY and then we'll integrate it |
|
@vblagoje can you guide me on where to do this? |
|
@vblagoje will it be at line number 55? |
|
Yes correct. But also add examples for text and document embedder. You worked on it, correct? |
|
@vblagoje but i'm supporting only GOOGLE_API_KEY key in that, not GEMINI_API_KEY, Because embedding models was not from Gemini Family |
…tails and add examples for document and text embedding.
|
@vblagoje, I have added the information you requested. Could you please review it and let me know if anything is required? |
|
|
||
| ### Document Embedding | ||
|
|
||
| To use Google model for embedding generation, set the `GOOGLE_API_KEY` environment variable and then initialize a `GoogleGenAIDocumentEmbedder`: |
|
|
||
| ### Text Embedding | ||
|
|
||
| To use Google model for embedding generation, set the `GOOGLE_API_KEY` environment variable and then initialize a `GoogleGenAITextEmbedder`: |
…ment and text embedding initialization
|
@vblagoje Done, add there too. |
|
Added a few comments as we are about to integrate deepset-ai/haystack-core-integrations#1928 |
|
@vblagoje, So should I pick those changes? |
Done already, we'll merge that PR first and then this one. |
|
@vblagoje Thank you so much! Excited to see my name in integrations. |
bilgeyucel
left a comment
There was a problem hiding this comment.
Thank you for the PR @garybadwal! I left my comments to make embedding support more prominent 🙌
|
|
||
| Once installed, you will have access to the Haystack Chat Generator: | ||
|
|
||
| - [`GoogleGenAIChatGenerator`](https://docs.haystack.deepset.ai/docs/googlegenaichatgenerator): Use this component with [Gemini models](https://ai.google.dev/gemini-api/docs/models/gemini#model-variations), such as '**gemini-2.0-flash**' for chat completion and function calling. |
There was a problem hiding this comment.
Can you list the GoogleGenAIDocumentEmbedder and GoogleGenAITextEmbedder components here?
|
|
||
| [Google Gen AI](https://ai.google.dev/) provides access to Google's Gemini models through the new Google Gen AI SDK. This integration enables the usage of Google's latest generative models via the updated API interface. | ||
|
|
||
| Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) including **gemini-2.0-flash** for tasks such as **chat completion**, **function calling**, and **streaming responses**. |
There was a problem hiding this comment.
| Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) including **gemini-2.0-flash** for tasks such as **chat completion**, **function calling**, and **streaming responses**. | |
| Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) like `gemini-2.0-flash` and `text-embedding-004` for tasks such as **chat completion**, **function calling**, **streaming responses** and **embedding generation**. |
|
|
||
| ## Usage | ||
|
|
||
| Once installed, you will have access to the Haystack Chat Generator: |
There was a problem hiding this comment.
| Once installed, you will have access to the Haystack Chat Generator: | |
| Once installed, you will have access to the Haystack components: |
| - [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash) | ||
| - [Streaming Chat Generation](#streaming-chat-generation) | ||
| - [Function calling](#function-calling) |
There was a problem hiding this comment.
| - [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash) | |
| - [Streaming Chat Generation](#streaming-chat-generation) | |
| - [Function calling](#function-calling) | |
| - [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash) | |
| - [Streaming Chat Generation](#streaming-chat-generation) | |
| - [Function calling](#function-calling) | |
| - [Document Embedding](#document-embedding) | |
| - [Text Embedding](#text-embedding) |
…l and clarify usage of document embedder
…ify components for chat and embedding functionalities
|
@bilgeyucel I have done the changes,
I have added this information, but there is no Docs page for the embedder integrations. Let me know what to do about this. |
You can leave it as it is right now. We'll add doc page links later |
Uh oh!
There was an error while loading. Please reload this page.