Skip to content

Add author info for Gary Badwal in Google GenAI integration (TextEmbedder & DocumentEmbedder)#333

Merged
bilgeyucel merged 7 commits into
deepset-ai:mainfrom
garybadwal:google_genai
Jun 12, 2025
Merged

Add author info for Gary Badwal in Google GenAI integration (TextEmbedder & DocumentEmbedder)#333
bilgeyucel merged 7 commits into
deepset-ai:mainfrom
garybadwal:google_genai

Conversation

@garybadwal
Copy link
Copy Markdown
Contributor

@garybadwal garybadwal commented Jun 10, 2025

  1. Adds integration for Google GenAI Text Embedder and Document Embedder.
  2. These embedders enable users to leverage Google GenAI's embedding models to enhance RAG (Retrieval-Augmented Generation) pipelines.

@garybadwal garybadwal requested a review from a team as a code owner June 10, 2025 08:26
@garybadwal
Copy link
Copy Markdown
Contributor Author

Hi @sjrl,
I've added the author information as per your suggestion. Could you please take a look and let me know if everything looks correct or if any further changes are needed?

@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Jun 10, 2025

Hey @garybadwal please wait for this PR #332 to be merged before you open a new one to add author information. Please coordinate with @vblagoje and @bilgeyucel on this.

@garybadwal
Copy link
Copy Markdown
Contributor Author

Ok @sjrl, Thank you.

Hi @bilgeyucel, @vblagoje, can any of you guide me into this?

@garybadwal
Copy link
Copy Markdown
Contributor Author

Hi @vblagoje — I'm just checking in to see if you might have a chance to review this PR and guide me if needed. Appreciate your time!

@vblagoje
Copy link
Copy Markdown
Member

@bilgeyucel let's integrate this one please 👍

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje Thanks for your comment on this. Please let me know if there's anything I can do on my end.

@vblagoje
Copy link
Copy Markdown
Member

No @garybadwal let's just wait for @bilgeyucel - she's super busy atm and she'll take care of this tomorrow.

@garybadwal
Copy link
Copy Markdown
Contributor Author

Ok @vblagoje, thank you so much for your help! Hopefully, @bilgeyucel will be able to check it when she gets a chance.

@vblagoje vblagoje self-requested a review June 12, 2025 09:13
@vblagoje
Copy link
Copy Markdown
Member

@garybadwal please update the tile to indicate that we also support GEMINI_API_KEY in addition to GOOGLE_API_KEY and then we'll integrate it

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje can you guide me on where to do this?

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje will it be at line number 55?

@vblagoje
Copy link
Copy Markdown
Member

Yes correct. But also add examples for text and document embedder. You worked on it, correct?

@garybadwal
Copy link
Copy Markdown
Contributor Author

garybadwal commented Jun 12, 2025

@vblagoje but i'm supporting only GOOGLE_API_KEY key in that, not GEMINI_API_KEY, Because embedding models was not from Gemini Family

…tails and add examples for document and text embedding.
@garybadwal
Copy link
Copy Markdown
Contributor Author

garybadwal commented Jun 12, 2025

@vblagoje, I have added the information you requested. Could you please review it and let me know if anything is required?

Comment thread integrations/google-genai.md Outdated

### Document Embedding

To use Google model for embedding generation, set the `GOOGLE_API_KEY` environment variable and then initialize a `GoogleGenAIDocumentEmbedder`:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or GEMINI_API_KEY

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread integrations/google-genai.md Outdated

### Text Embedding

To use Google model for embedding generation, set the `GOOGLE_API_KEY` environment variable and then initialize a `GoogleGenAITextEmbedder`:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or GEMINI_API_KEY

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje Done, add there too.

@vblagoje
Copy link
Copy Markdown
Member

Added a few comments as we are about to integrate deepset-ai/haystack-core-integrations#1928

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje, So should I pick those changes?

@vblagoje
Copy link
Copy Markdown
Member

@vblagoje, So should I pick those changes?

Done already, we'll merge that PR first and then this one.

@garybadwal
Copy link
Copy Markdown
Contributor Author

@vblagoje Thank you so much! Excited to see my name in integrations.

Copy link
Copy Markdown
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @garybadwal! I left my comments to make embedding support more prominent 🙌


Once installed, you will have access to the Haystack Chat Generator:

- [`GoogleGenAIChatGenerator`](https://docs.haystack.deepset.ai/docs/googlegenaichatgenerator): Use this component with [Gemini models](https://ai.google.dev/gemini-api/docs/models/gemini#model-variations), such as '**gemini-2.0-flash**' for chat completion and function calling.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the GoogleGenAIDocumentEmbedder and GoogleGenAITextEmbedder components here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread integrations/google-genai.md Outdated

[Google Gen AI](https://ai.google.dev/) provides access to Google's Gemini models through the new Google Gen AI SDK. This integration enables the usage of Google's latest generative models via the updated API interface.

Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) including **gemini-2.0-flash** for tasks such as **chat completion**, **function calling**, and **streaming responses**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) including **gemini-2.0-flash** for tasks such as **chat completion**, **function calling**, and **streaming responses**.
Haystack supports the latest [Gemini models](https://ai.google.dev/models/gemini) like `gemini-2.0-flash` and `text-embedding-004` for tasks such as **chat completion**, **function calling**, **streaming responses** and **embedding generation**.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread integrations/google-genai.md Outdated

## Usage

Once installed, you will have access to the Haystack Chat Generator:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once installed, you will have access to the Haystack Chat Generator:
Once installed, you will have access to the Haystack components:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines +31 to +33
- [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash)
- [Streaming Chat Generation](#streaming-chat-generation)
- [Function calling](#function-calling)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash)
- [Streaming Chat Generation](#streaming-chat-generation)
- [Function calling](#function-calling)
- [Chat Generation with `gemini-2.0-flash`](#chat-generation-with-gemini-20-flash)
- [Streaming Chat Generation](#streaming-chat-generation)
- [Function calling](#function-calling)
- [Document Embedding](#document-embedding)
- [Text Embedding](#text-embedding)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

…ify components for chat and embedding functionalities
@garybadwal
Copy link
Copy Markdown
Contributor Author

@bilgeyucel I have done the changes,
For this review:

Can you list the GoogleGenAIDocumentEmbedder and GoogleGenAITextEmbedder components here?

I have added this information, but there is no Docs page for the embedder integrations. Let me know what to do about this.

@bilgeyucel
Copy link
Copy Markdown
Contributor

@bilgeyucel I have done the changes, For this review:

Can you list the GoogleGenAIDocumentEmbedder and GoogleGenAITextEmbedder components here?

I have added this information, but there is no Docs page for the embedder integrations. Let me know what to do about this.

You can leave it as it is right now. We'll add doc page links later

@bilgeyucel bilgeyucel merged commit b705ca1 into deepset-ai:main Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants